Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems of roundings in the cvpImageCircle::omputeAngularCoverageInRoI #1268

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

rolalaro
Copy link

A rouding problem was introduced by the use of M_PIf .
The result of the method is now ensured to be between 0 and 2 Pi.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fa84fee) 54.38% compared to head (084d1b8) 54.37%.

❗ Current head 084d1b8 differs from pull request most recent head e03dfe3. Consider uploading reports for the commit e03dfe3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   54.38%   54.37%   -0.01%     
==========================================
  Files         400      400              
  Lines       50486    50503      +17     
==========================================
+ Hits        27456    27461       +5     
- Misses      23030    23042      +12     
Files Coverage Δ
modules/core/include/visp3/core/vpImageCircle.h 50.00% <100.00%> (+50.00%) ⬆️
modules/core/include/visp3/core/vpMath.h 92.10% <100.00%> (+0.43%) ⬆️
modules/core/src/image/vpImageCircle.cpp 92.19% <90.00%> (-0.23%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…FIX] Corrected visibility check for single axis crossing
@fspindle fspindle merged commit 6582d80 into lagadic:master Oct 31, 2023
49 of 50 checks passed
@rolalaro rolalaro deleted the fixVpImageCircle branch January 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants