Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canny #1278

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Fix canny #1278

merged 3 commits into from
Nov 24, 2023

Conversation

rolalaro
Copy link

Improved the ViSP Canny implementation by :

  • changing the edge thinning algorithm
  • considering only the gradient points having a value greater than the lower threshold

To test with the result of Canny by OpenCV beside the ViSP implementation result:

./tutorial-canny -t -1 -1 -r 0.4 0.95 -b opencv-backend --image

Here is a dataset that can be used to have a look at the capabilities of the new implementation:
testCanny.zip

@fspindle
Copy link
Contributor

@rolalaro Seems ok to me. I have just the feeling that using -r 0.4 0.85 gives results much closer to the one obtained with OpenCV backend.

Could be seen especially on cube.ppm image. On mire.png the values are more around -r 0.4 0.9.

Anyway, I will merge.

@fspindle fspindle merged commit 5be33d4 into lagadic:master Nov 24, 2023
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants