-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix canny #1287
Fix canny #1287
Conversation
@@ -235,7 +235,7 @@ vpCannyEdgeDetection::performFilteringAndGradientComputation(const vpImage<unsig | |||
/** | |||
* \brief Get the interpolation weights and offsets. | |||
* | |||
* \param[in] absoluteTheta : The absolute value of the angle of the edge, expressed in degrees. | |||
* \param[in] positiveTheta : The positive value of the angle of the edge, expressed in degrees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be complete, you could precise that this angle is between -180 and +180 deg (or \f$-\pi,+\pi\f$ see below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good reason to consider degrees instead of rad? Using deg means that to have to call vpMath::rad()
that is useless
antan2() is returning rad
You can use M_PI_2
and M_PI_4
macros
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to rename positiveTheta
into gradientOrientation
to be more explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These suggestions have been addressed in the new commit e459437
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
+ Coverage 54.41% 54.43% +0.01%
==========================================
Files 400 400
Lines 50512 50514 +2
==========================================
+ Hits 27487 27496 +9
+ Misses 23025 23018 -7 ☔ View full report in Codecov by Sentry. |
…iveGradient for gradientOrientation that is more understandable
Fix two problems :