Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warnings #1289

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

rolalaro
Copy link

@rolalaro rolalaro commented Dec 6, 2023

Fix compilation warnings on Windows in the class vpImageFilter
Fix some warnings detected by SonarQube

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (e4338fe) 54.43% compared to head (3855247) 54.42%.
Report is 5 commits behind head on master.

Files Patch % Lines
modules/core/include/visp3/core/vpImageFilter.h 83.41% 33 Missing ⚠️
modules/core/src/image/vpImageFilter.cpp 44.00% 28 Missing ⚠️
modules/core/src/image/vpImageConvert.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
- Coverage   54.43%   54.42%   -0.01%     
==========================================
  Files         400      400              
  Lines       50514    50516       +2     
==========================================
- Hits        27496    27495       -1     
- Misses      23018    23021       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit 35e3502 into lagadic:master Dec 7, 2023
52 checks passed
@rolalaro rolalaro deleted the fixCompilationWarnings branch January 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants