Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat with 3rdparties #1292

Merged
merged 9 commits into from
Dec 19, 2023
Merged

Feat with 3rdparties #1292

merged 9 commits into from
Dec 19, 2023

Conversation

fspindle
Copy link
Contributor

For specific industrial projects, it is useful to deactivate embedded third parties, or even to delete the associated source code completely.

This PR introduce new options (WITH_PUGIXML, WITH_STBIMAGE, WITH_SIMDLIB, WITH_TINYEXR) to this end.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 272 lines in your changes are missing coverage. Please review.

Comparison is base (dcfe00a) 54.27% compared to head (9e63de2) 53.76%.
Report is 177 commits behind head on master.

Files Patch % Lines
...sion/src/homography-estimation/vpHomographyVVS.cpp 0.00% 78 Missing ⚠️
.../vision/src/homography-estimation/vpHomography.cpp 24.21% 72 Missing ⚠️
.../src/homography-estimation/vpHomographyExtract.cpp 53.48% 40 Missing ⚠️
...n/src/homography-estimation/vpHomographyRansac.cpp 50.87% 28 Missing ⚠️
modules/tracker/mbt/src/edge/vpMbEdgeTracker.cpp 15.78% 16 Missing ⚠️
...sion/src/homography-estimation/vpHomographyDLT.cpp 83.78% 12 Missing ⚠️
modules/tracker/mbt/src/klt/vpMbKltTracker.cpp 30.00% 7 Missing ⚠️
...s/tracker/mbt/src/depth/vpMbDepthNormalTracker.cpp 50.00% 5 Missing ⚠️
...on/src/homography-estimation/vpHomographyMalis.cpp 95.49% 5 Missing ⚠️
...es/tracker/mbt/src/depth/vpMbDepthDenseTracker.cpp 33.33% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
- Coverage   54.27%   53.76%   -0.52%     
==========================================
  Files         400      400              
  Lines       50658    50862     +204     
==========================================
- Hits        27497    27347     -150     
- Misses      23161    23515     +354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit 8ef760d into lagadic:master Dec 19, 2023
51 of 52 checks passed
@fspindle fspindle deleted the feat_with_3rdparties branch July 3, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant