Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cam parser #1297

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Fix cam parser #1297

merged 5 commits into from
Jan 5, 2024

Conversation

rolalaro
Copy link

@rolalaro rolalaro commented Jan 4, 2024

PR to solve Issue #1296

  • Added a test in testXmlParserCamera to check if the parse method handles a file containing a single camera when no name is given to the camera
  • FIx the problem: the test same_name was wrong.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc36909) 53.60% compared to head (8f5381c) 53.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1297      +/-   ##
==========================================
- Coverage   53.60%   53.58%   -0.02%     
==========================================
  Files         399      399              
  Lines       50512    50512              
==========================================
- Hits        27077    27068       -9     
- Misses      23435    23444       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit 0d2fb23 into lagadic:master Jan 5, 2024
52 checks passed
@rolalaro rolalaro deleted the fix_cam_parser branch January 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants