Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tutorial to explain how to build python bindings #1312

Merged
merged 15 commits into from
Mar 20, 2024

Conversation

fspindle
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.81%. Comparing base (ebfa260) to head (51adb9c).
Report is 205 commits behind head on master.

❗ Current head 51adb9c differs from pull request most recent head e161820. Consider uploading reports for the commit e161820 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
- Coverage   53.60%   52.81%   -0.80%     
==========================================
  Files         399      411      +12     
  Lines       50509    52740    +2231     
==========================================
+ Hits        27076    27855     +779     
- Misses      23433    24885    +1452     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/tutorial/python/tutorial-install-python-bindings.dox Outdated Show resolved Hide resolved
doc/tutorial/python/tutorial-install-python-bindings.dox Outdated Show resolved Hide resolved
(visp-conda-ws) $ conda install pybind11

Proceed ([y]/n)? y

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably tell the user that he can install Visp other dependencies here, even if they are optional for compiling Visp. This would solve the missing X11 library error we encounter just next, so at least this one should be installed.
May be something like:

- At this point, you can also install ViSP other dependencies using conda depending on which features you want to be compiled. You will need to install at least the X11 libraries:
     (visp-conda-ws) $ conda install xorg-libx11
  
  However, we recommend this minimal set of dependencies to get the main features of ViSP available:
     (visp-conda-ws) $ conda install xorg-libx11 eigen libopencv libjpeg-turbo libpng

doc/tutorial/python/tutorial-install-python-bindings.dox Outdated Show resolved Hide resolved
@fspindle fspindle merged commit f243bc1 into lagadic:master Mar 20, 2024
35 of 36 checks passed
@fspindle fspindle deleted the feat_doc_python_bindings branch July 3, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants