Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce again cxx98 support #1323

Merged
merged 13 commits into from
Feb 2, 2024
Merged

Conversation

fspindle
Copy link
Contributor

@fspindle fspindle commented Feb 1, 2024

No description provided.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 403 lines in your changes are missing coverage. Please review.

Comparison is base (4b51e2c) 52.45% compared to head (6e4c53e) 52.53%.
Report is 7 commits behind head on master.

Files Patch % Lines
...odules/tracker/me/src/moving-edges/vpMeEllipse.cpp 66.40% 86 Missing ⚠️
modules/tracker/me/src/moving-edges/vpMeLine.cpp 60.41% 76 Missing ⚠️
modules/tracker/me/src/moving-edges/vpMeNurbs.cpp 0.00% 75 Missing ⚠️
modules/tracker/me/src/moving-edges/vpMeSite.cpp 72.72% 36 Missing ⚠️
...odules/tracker/me/src/moving-edges/vpMeTracker.cpp 50.76% 32 Missing ⚠️
modules/tracker/mbt/src/edge/vpMbtMeEllipse.cpp 0.00% 24 Missing ⚠️
modules/tracker/mbt/src/edge/vpMbtMeLine.cpp 83.82% 22 Missing ⚠️
...tracker/mbt/include/visp3/mbt/vpMbEdgeKltTracker.h 40.00% 6 Missing ⚠️
...les/tracker/mbt/include/visp3/mbt/vpMbKltTracker.h 0.00% 5 Missing ⚠️
modules/tracker/me/src/moving-edges/vpMe.cpp 94.11% 5 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
+ Coverage   52.45%   52.53%   +0.07%     
==========================================
  Files         401      401              
  Lines       51826    51959     +133     
==========================================
+ Hits        27187    27298     +111     
- Misses      24639    24661      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit fdcb114 into lagadic:master Feb 2, 2024
51 of 52 checks passed
@fspindle fspindle deleted the feat_cxx98_come_back branch July 3, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant