Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the ubuntu-isolated.yml file #1328

Merged

Conversation

s-trinh
Copy link
Contributor

@s-trinh s-trinh commented Feb 4, 2024

cf #1327

Try skipping the following jobs when `[skip-ci]` tag is present in the commit message:
- .github/workflows/coverage.yml
- .github/workflows/ios.yml
- .github/workflows/macos-ustk.yml
- .github/workflows/other-arch.yml
- .github/workflows/ubuntu-3rdparty.yml
- .github/workflows/ubuntu-contrib.yml
- .github/workflows/ubuntu-ustk.yml

[Update]:
Following does not work:

# https://stackoverflow.com/questions/59759921/how-to-skip-github-actions-job-on-push-event#comment110153861_59775665
if: "!contains(toJSON(github.event.commits.*.message), '[skip-ci]')"

@s-trinh s-trinh force-pushed the feat_emulate_ROS2_Jenkins_env_fix_typo branch 3 times, most recently from d7bee73 to 31c7902 Compare February 6, 2024 18:38
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b370a00) 52.56% compared to head (cede9f5) 52.52%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1328      +/-   ##
==========================================
- Coverage   52.56%   52.52%   -0.05%     
==========================================
  Files         401      399       -2     
  Lines       51969    51970       +1     
==========================================
- Hits        27320    27295      -25     
- Misses      24649    24675      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s-trinh s-trinh force-pushed the feat_emulate_ROS2_Jenkins_env_fix_typo branch from c8eb4ca to e6024c9 Compare February 7, 2024 21:20
@fspindle
Copy link
Contributor

fspindle commented Feb 8, 2024

@s-trinh One possibility would be to disable remaining 3rd parties during cmake configuration (-DUSE_JPEG=OFF -DUSE_PNG=OFF -DUSE_OPENMP=OFF -DUSE_X11=OFF -DUSE_XML2=OFF -DUSE_ZLIB=OFF)

@s-trinh s-trinh force-pushed the feat_emulate_ROS2_Jenkins_env_fix_typo branch from e6024c9 to 149394d Compare February 8, 2024 20:49
@s-trinh
Copy link
Contributor Author

s-trinh commented Feb 8, 2024

@fspindle Thanks, let's try it like this.

TODO:

  • disable Java
  • disable GSL

@fspindle fspindle merged commit b9b017f into lagadic:master Feb 10, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants