Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc improvement and vpImage refactoring #1352

Merged
merged 33 commits into from
Mar 20, 2024

Conversation

fspindle
Copy link
Contributor

  • Remove all svn export mention in the doxygen tutorials since this trick doesn't allow anymore to download single files from a github repo
  • Refactor vpImage following functions getSum(), getMeanValue() and getStdev() with the objective to reduce the number of functions by overloading and using pointers when parameters are optional

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 86.86869% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 52.81%. Comparing base (f243bc1) to head (1e5455c).

Files Patch % Lines
modules/core/include/visp3/core/vpImage.h 89.88% 9 Missing ⚠️
modules/imgproc/src/vpImgproc.cpp 60.00% 2 Missing ⚠️
...es/core/src/math/misc/vpStatisticalTestHinkley.cpp 66.66% 1 Missing ⚠️
modules/imgproc/src/vpCircleHoughTransform.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   52.82%   52.81%   -0.02%     
==========================================
  Files         411      411              
  Lines       52740    52737       -3     
==========================================
- Hits        27862    27853       -9     
- Misses      24878    24884       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fspindle added 25 commits March 18, 2024 08:41
…le time

- These build options where not added when cmake run once
- They were added using ccmake or when cmake launched 2 or more times
- change the way package version is retrieved using pkg-config
Allow to remove this cmake warning on macos:
-- Found PythonLibs: /opt/homebrew/Frameworks/Python.framework/Versions/3.12/lib/libpython3.12.dylib (found suitable exact version "3.12.1")
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: module 'numpy.distutils' has no attribute 'misc_util'
@fspindle fspindle merged commit 358d855 into lagadic:master Mar 20, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant