-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] New photometric VS features + improvements to vpFeatureLuminance #1359
Conversation
If the CI is ok, this PR can be merged. I will write a followup PR to implement the remaining features when I have some time :) |
…y on shared ptr and other C++11 features
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1359 +/- ##
==========================================
+ Coverage 45.55% 45.86% +0.30%
==========================================
Files 1082 1086 +4
Lines 109238 109887 +649
Branches 18658 18876 +218
==========================================
+ Hits 49767 50396 +629
- Misses 59471 59491 +20 ☔ View full report in Codecov by Sentry. |
This PR introduces new visual servoing features, taken from the papers of Eric Marchand and readapted from his code.
These features are PCA and DCT compressed representations of the luminance information.
In terms of implementation, new classes are introduced:
vpFeatureLuminanceMapping
a visual servoing feature, which combines avpFeatureLuminance
object with avpLuminanceMapping
subobject. This is the feature that is given tovpServo
vpLuminanceMapping
, a common interface for mappings that operate on luminance information. amap
method computes a vector representation from the image. Theinverse
method, converts this vector back to an image, with some information loss. Finally, theinteraction
method computes the Jacobian, given the image, the compressed representation and the photometric Jacobian (computed beforehand byvpFeatureLuminance
when used with thevpFeatureLuminanceMapping
)vpLuminanceMapping
interface has two implementations:vpLuminancePCA
andvpLuminanceDCT
. they can be used interchangeably invpFeatureLuminanceMapping
Before this PR is complete, several things are lacking:
vpFeatureLuminance