Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of the git tag with new ViSP tag naming #1372

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

s-trinh
Copy link
Contributor

@s-trinh s-trinh commented Apr 14, 2024

Before:

more ViSP-third-party.txt 

==========================================================
General configuration information for ViSP 3.6.1

  Version control:               3.2.0-3608-gcef7d8d0e

Now:

more ViSP-third-party.txt 

==========================================================
General configuration information for ViSP 3.6.1

  Version control:               v3.6.0-789-g0a12cf235

git describe --tags --always --dirty
v3.6.0-788-gcef7d8d0e

git describe --tags --always --dirty --match "[0-9].[0-9].[0-9]*"
3.2.0-3608-gcef7d8d0e

git describe --tags --always --dirty --match "v[0-9].[0-9].[0-9]*"
v3.6.0-788-gcef7d8d0e

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.63%. Comparing base (1675840) to head (0a12cf2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1372   +/-   ##
=======================================
  Coverage   45.63%   45.63%           
=======================================
  Files        1069     1069           
  Lines      108080   108080           
  Branches    18710    18710           
=======================================
  Hits        49325    49325           
  Misses      58755    58755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle
Copy link
Contributor

@s-trinh Thanks

@fspindle fspindle merged commit e56c8a1 into lagadic:master Apr 14, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants