Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply misra c++ quality rules mainly to headers #1400

Merged
merged 5 commits into from
May 14, 2024
Merged

Apply misra c++ quality rules mainly to headers #1400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59e51bb
Apply misra c++ quality rules mainly to headers
fspindle May 13, 2024
89f9f89
Fix since vpColvector constructors are explicit
fspindle May 13, 2024
632b536
More fixes since some constructors are explicit
fspindle May 13, 2024
b476f69
Fix doxygen warning
fspindle May 14, 2024
1056d74
Fix vp_add_subdirectory that produced an issue on macos complaining a…
fspindle May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmake/VISPUtils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,10 @@ macro(vp_add_subdirectories lst subdir)
file(GLOB __subdirs RELATIVE "${__path}/${subdir}" "${__path}/${subdir}/*")
foreach(__s ${__subdirs})
if(EXISTS "${__path}/${subdir}/${__s}/CMakeLists.txt")
add_subdirectory("${__path}/${subdir}/${__s}" "${CMAKE_BINARY_DIR}/${subdir}/${__s}")
# Add subdir only if ut doesn't exist
if(NOT EXISTS "${CMAKE_BINARY_DIR}/${subdir}/${__s}")
add_subdirectory("${__path}/${subdir}/${__s}" "${CMAKE_BINARY_DIR}/${subdir}/${__s}")
endif()
endif()
endforeach()
endif()
Expand Down
6 changes: 3 additions & 3 deletions example/manual/image-manipulation/manGrab1394.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
*
*****************************************************************************/
/*!
\file manGrab1394-2.cpp
\file manGrab1394.cpp

\brief Images grabbing example with the vp1394TwoGrabber class.

*/
/*!
\example manGrab1394-2.cpp
\example manGrab1394.cpp

\brief Images grabbing example with the vp1394TwoGrabber class.

Expand Down Expand Up @@ -76,7 +76,7 @@ int main()
g.acquire(I[camera]);
}
}
delete [] I;
delete[] I;
return EXIT_SUCCESS;
}
catch (const vpException &e) {
Expand Down
4 changes: 2 additions & 2 deletions example/robot-simulator/camera/servoSimu3D_cMcd_CamVelocityWithoutVpServo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
* This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
* WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
*
* Description:
* Description
* Simulation of a 3D visual servoing.
*
*****************************************************************************/
Expand Down Expand Up @@ -267,7 +267,7 @@ int main(int argc, const char **argv)

// Compute the camera translational velocity
vpColVector v(3);
v = lambda * (I - vpColVector::skew(tu_cRcd)) * ctcd;
v = lambda * (I - vpColVector::skew(vpColVector(tu_cRcd))) * ctcd;
// Compute the camera rotational velocity
vpColVector w(3);
w = lambda * tu_cRcd;
Expand Down
Loading
Loading