-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial nix packaging #1416
Initial nix packaging #1416
Conversation
eigen, | ||
#fetchFromGitHub, | ||
lapack, | ||
lib, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my understanding to what does lib
refer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add the following dependencies
libjpeg-turbo
pkg-config
for usage without cmakelibX11
if not the case by defaultlibrealsense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib
is a collection of nix code inside nixpkgs, with both helpers and common data: https://github.com/nixOS/nixpkgs/blob/master/lib/README.md
Here, I'm only using it for the following:
nix-repl> pkgs.lib.licenses.gpl2Plus
{ deprecated = false; free = true; fullName = "GNU General Public License v2.0 or later"; redistributable = true; shortName = "gpl2Plus"; spdxId = "GPL-2.0-or-later"; url = "https://spdx.org/licenses/GPL-2.0-or-later.html"; }
nix-repl> pkgs.lib.maintainers.nim65s
{ email = "[email protected]"; github = "nim65s"; githubId = 131929; keys = [ ... ]; matrix = "@gsaurel:laas.fr"; name = "Guilhem Saurel"; }
@nim65s Thanks for this nice contribution.
I added other deps in the code review
No. I need to check.
I don't know. I will investigate and let you know... |
@nim65s Thanks Guilhem. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1416 +/- ##
=======================================
Coverage 45.59% 45.59%
=======================================
Files 1082 1082
Lines 109215 109215
Branches 18758 18758
=======================================
Hits 49792 49792
Misses 59423 59423 ☔ View full report in Codecov by Sentry. |
Hello !
This PR includes:
-DCMAKE_INSTALL_LIBDIR=/an/absolute/path
visp
package in nix, and a flake.nix file to easily build and use this package. At some point, we will want to move this default.nix to https://github.com/NixOS/nixpkgs/, and just override thesrc
attribute in the flake to use the local version instead.I have a few questions:
Also, nix macos packaging is not done yet. I'll probably be able to find some time to deal with this, but not today, and maybe not this week.