Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial nix packaging #1416

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Initial nix packaging #1416

merged 4 commits into from
Jun 11, 2024

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented May 28, 2024

Hello !

This PR includes:

  1. a CMake fix for use cases where users (or package managers) set eg. -DCMAKE_INSTALL_LIBDIR=/an/absolute/path
  2. a default.nix file which create a basic visp package in nix, and a flake.nix file to easily build and use this package. At some point, we will want to move this default.nix to https://github.com/NixOS/nixpkgs/, and just override the src attribute in the flake to use the local version instead.
  3. a github action to test this nix setup.

I have a few questions:

  • did I miss important dependencies / options ?
  • visp do not compile correctly with ogre v14.2.5. Is this known ? What should we do about it ?
  • contributing guidelines provide a "Copyright Assignment Agreement for an Individual Contributor". I am not in an individual position, but with CNRS. What should we do about that ?

Also, nix macos packaging is not done yet. I'll probably be able to find some time to deal with this, but not today, and maybe not this week.

@nim65s nim65s changed the title Nix packaging Initial nix packaging May 28, 2024
eigen,
#fetchFromGitHub,
lapack,
lib,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding to what does lib refer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add the following dependencies

  • libjpeg-turbo
  • pkg-config for usage without cmake
  • libX11 if not the case by default
  • librealsense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib is a collection of nix code inside nixpkgs, with both helpers and common data: https://github.com/nixOS/nixpkgs/blob/master/lib/README.md

Here, I'm only using it for the following:

nix-repl> pkgs.lib.licenses.gpl2Plus
{ deprecated = false; free = true; fullName = "GNU General Public License v2.0 or later"; redistributable = true; shortName = "gpl2Plus"; spdxId = "GPL-2.0-or-later"; url = "https://spdx.org/licenses/GPL-2.0-or-later.html"; }

nix-repl> pkgs.lib.maintainers.nim65s
{ email = "[email protected]"; github = "nim65s"; githubId = 131929; keys = [ ... ]; matrix = "@gsaurel:laas.fr"; name = "Guilhem Saurel"; }

@fspindle
Copy link
Contributor

@nim65s Thanks for this nice contribution.

did I miss important dependencies / options ?

I added other deps in the code review

visp do not compile correctly with ogre v14.2.5. Is this known ? What should we do about it ?

No. I need to check.

contributing guidelines provide a "Copyright Assignment Agreement for an Individual Contributor". I am not in an individual position, but with CNRS. What should we do about that ?

I don't know. I will investigate and let you know...

@fspindle
Copy link
Contributor

fspindle commented Jun 4, 2024

@nim65s Thanks Guilhem.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.59%. Comparing base (68deeca) to head (69c444a).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1416   +/-   ##
=======================================
  Coverage   45.59%   45.59%           
=======================================
  Files        1082     1082           
  Lines      109215   109215           
  Branches    18758    18758           
=======================================
  Hits        49792    49792           
  Misses      59423    59423           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit 8283097 into lagadic:master Jun 11, 2024
74 of 76 checks passed
@nim65s nim65s mentioned this pull request Aug 9, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants