Backport most of the changes from main AprilTag repo as of 188c0e0 version #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-trinh
force-pushed
the
update_apriltag_as_of_188c0e0
branch
2 times, most recently
from
d908db0 to
d9ee45f
Compare
s-trinh
force-pushed
the
update_apriltag_as_of_188c0e0
branch
from
d9ee45f to
c8fabc6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1440 +/- ##
==========================================
- Coverage 45.20% 45.19% -0.02%
==========================================
Files 1106 1108 +2
Lines 110078 110123 +45
Branches 18866 18869 +3
==========================================
+ Hits 49766 49775 +9
- Misses 60312 60348 +36 ☔ View full report in Codecov by Sentry. |
|
@s-trinh Thanks I will merge this PR since the remaining issues pointed by the ci are not related to theses changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to backport most of the changes from https://github.com/AprilRobotics/apriltag/tree/188c0e025d13a607c07d294ac40be604d6598974
Individual commits:
MR: