MacOS / Ubuntu CI for ViSP namespace #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e namespace option
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1443 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 1108 1108
Lines 110137 110137
Branches 18873 18874 +1
=======================================
Hits 49895 49895
Misses 60242 60242 ☔ View full report in Codecov by Sentry. |
fspindle
reviewed
Jul 18, 2024
| run: | | ||
| sudo apt-get update && sudo apt-get install -y libjpeg-dev libpng-dev libopencv-dev libpcl-dev libx11-dev liblapack-dev libeigen3-dev libv4l-dev libzbar-dev libpthread-stubs0-dev libdc1394-dev nlohmann-json3-dev | ||
|
|
||
| - name: Install dependencies on macos-13 |
There was a problem hiding this comment.
All this block dedicated to macos-13 could be removed
| echo "VISP_INPUT_IMAGE_PATH=$HOME/visp-images" >> $GITHUB_ENV | ||
| echo ${VISP_INPUT_IMAGE_PATH} | ||
|
|
||
| - name: Clone visp_sample |
There was a problem hiding this comment.
You could also remove clonning visp_sample. Not used later
…ple (because not used)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to create a new CI based on Ubuntu and MacOS to test ViSP when the namespace flag is activated