Feat apriltag upgrade #1448
Merged
Feat apriltag upgrade #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 3806edf38ac4400153677e510c9f9dcb81f472c8 Date: Sun Jul 7 12:38:22 2024 +0200 Changes to keep files as close as possible to https://github.com/AprilRobotics/apriltag Remove pthreads4w 3rdparty since apriltag 3rdparty embbed pthreads_cross for windows. apriltag 3rdparty is now build as a C library (files have .c extension)
C:/mingw-w64/x86_64-8.1.0-posix-seh-rt_v6-rev0/mingw64/bin/c++.exe (ver 8.1.0) pthreads_cross.h:37:26: error: conflicting declaration 'typedef CRITICAL_SECTION pthread_mutex_t' pthreads_cross.c:110:5: warning: implicit declaration of function 'InitializeConditionVariable'
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1448 +/- ##
=======================================
Coverage 45.42% 45.42%
=======================================
Files 1110 1110
Lines 110525 110528 +3
Branches 18923 18926 +3
=======================================
+ Hits 50203 50208 +5
+ Misses 60322 60320 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade apriltag 3rdparty with code as close as possible from the original repo https://april.eecs.umich.edu/software/apriltag.html
AprilTag version is 3.4.2.
commit 3806edf38ac4400153677e510c9f9dcb81f472c8
Date: Sun Jul 7 12:38:22 2024 +0200