-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications for the upcoming Render-Based Tracking submodule #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… management when closing framework
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1456 +/- ##
==========================================
+ Coverage 45.41% 45.42% +0.01%
==========================================
Files 1110 1110
Lines 110531 110643 +112
Branches 18925 18944 +19
==========================================
+ Hits 50199 50264 +65
- Misses 60332 60379 +47 ☔ View full report in Codecov by Sentry. |
…alue, resulting in an uneeded copy
fspindle
reviewed
Sep 3, 2024
@SamFlt Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces small modifications and improvements that were required for the Render-Based Tracking submodule that is coming soon (hopefully :-)). It contains:
vpMeSite
:trackMultipleHypotheses
, that retains the K best candidates instead of only one.track
code to cleanup code redundancy, removed the use of an array that was not needed.vpDisplayFactory
:makeDisplayGrid
that creates a display grid, initializing the displays with the given images. This supports variable grid size, with padding between displays.