CMake system include dirs to ignore 3rd party warnings

[SamFlt]

No description provided.

[fspindle]

@SamFlt Nice job. Works on my side.
But we need to investigate the following issue when ViSP is used as a 3rd party to build tutorial/ar

cp -p -r $VISP_WS/visp/tutorial/ar /tmp
cd /tmp/ar
mkdir build
cd build
cmake ../ -DVISP_DIR=$VISP_WS/visp-build
make

On my side it produces the following build error.

-- Configuring done (0.0s)
-- Generating done (0.0s)
-- Build files have been written to: /tmp/ar/build
[ 50%] Building CXX object CMakeFiles/tutorial-panda3d-renderer.dir/tutorial-panda3d-renderer.cpp.o
In file included from /tmp/ar/tutorial-panda3d-renderer.cpp:20:
In file included from /Users/fspindle/soft/visp/visp_ws/test-pr/visp-SamFlt/visp/modules/ar/include/visp3/ar/vpPanda3DRGBRenderer.h:38:
In file included from /Users/fspindle/soft/visp/visp_ws/test-pr/visp-SamFlt/visp/modules/ar/include/visp3/ar/vpPanda3DBaseRenderer.h:41:
In file included from /Library/Developer/Panda3D/include/pandaFramework.h:18:
In file included from /Library/Developer/Panda3D/include/config_framework.h:19:
In file included from /Library/Developer/Panda3D/include/windowProperties.h:21:
In file included from /Library/Developer/Panda3D/include/lpoint2.h:19:
In file included from /Library/Developer/Panda3D/include/lvecBase2.h:18:
In file included from /Library/Developer/Panda3D/include/config_linmath.h:20:
In file included from /Library/Developer/Panda3D/include/lsimpleMatrix.h:20:
In file included from /Library/Developer/Panda3D/include/Eigen/Dense:1:
In file included from /Library/Developer/Panda3D/include/Eigen/Core:276:
/Library/Developer/Panda3D/include/Eigen/src/Core/Functors.h:973:28: error: no member named 'binder2nd' in namespace 'std'
struct functor_traits<std::binder2nd<T> >
                      ~~~~~^
/Library/Developer/Panda3D/include/Eigen/src/Core/Functors.h:973:38: error: 'T' does not refer to a value
struct functor_traits<std::binder2nd<T> >
                                     ^
/Library/Developer/Panda3D/include/Eigen/src/Core/Functors.h:972:19: note: declared here
template<typename T>
                  ^
/Library/Developer/Panda3D/include/Eigen/src/Core/Functors.h:973:41: error: expected unqualified-id
struct functor_traits<std::binder2nd<T> >
                                        ^
/Library/Developer/Panda3D/include/Eigen/src/Core/Functors.h:977:28: error: no member named 'binder1st' in namespace 'std'
struct functor_traits<std::binder1st<T> >
                      ~~~~~^
/Library/Developer/Panda3D/include/Eigen/src/Core/Functors.h:977:38: error: 'T' does not refer to a value
struct functor_traits<std::binder1st<T> >
                                     ^
/Library/Developer/Panda3D/include/Eigen/src/Core/Functors.h:976:19: note: declared here
template<typename T>
                  ^
/Library/Developer/Panda3D/include/Eigen/src/Core/Functors.h:977:41: error: expected unqualified-id
struct functor_traits<std::binder1st<T> >
                                        ^
6 errors generated.
make[2]: *** [CMakeFiles/tutorial-panda3d-renderer.dir/tutorial-panda3d-renderer.cpp.o] Error 1
make[1]: *** [CMakeFiles/tutorial-panda3d-renderer.dir/all] Error 2
make: *** [all] Error 2

I will investigate tomorrow.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.25%. Comparing base (c1624ea) to head (4ffa1ba).
Report is 39 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1466      +/-   ##
==========================================
- Coverage   45.26%   45.25%   -0.01%     
==========================================
  Files        1121     1121              
  Lines      112131   112149      +18     
  Branches    19077    19080       +3     
==========================================
+ Hits        50751    50754       +3     
- Misses      61380    61395      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SamFlt]

Hey Fabien,

Did you compile Panda with the --no-eigen flag to see what happens?
This seems related to a really old Eigen issue: https://eigen.tuxfamily.org/bz/show_bug.cgi?id=872
In Ubuntu 22 (WSL), I installed Panda with everything (python makepanda/makepanda.py --everything --installer) and could successfully run the tutorial (after fixing some linking issues, see the last commit)
Do you have an old version of eigen on your mac?