Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixed the memorization of the voting points for the CHT #1502

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

rolalaro
Copy link

@rolalaro rolalaro commented Nov 6, 2024

The voting points vector was not reinitialized when evaluating a new center, it remembered the voting points for the same radii but other circles

The voting points vector was not reinitialized when evaluating a new center, it remembered the voting points for the same radii but other circles
@rolalaro rolalaro marked this pull request as draft November 6, 2024 09:44
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.84%. Comparing base (18e43f8) to head (53b3080).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
...les/imgproc/src/vpCircleHoughTransform_circles.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   53.88%   53.84%   -0.05%     
==========================================
  Files         442      442              
  Lines       53793    53850      +57     
==========================================
+ Hits        28987    28996       +9     
- Misses      24806    24854      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rolalaro rolalaro marked this pull request as ready for review November 7, 2024 15:19
@fspindle fspindle merged commit 8206553 into lagadic:master Nov 12, 2024
74 of 76 checks passed
@rolalaro rolalaro deleted the fix_cht_votes branch November 12, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants