Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python bindings doc for compiling in conda env #1506

Merged

Conversation

olivier-roussel
Copy link
Contributor

As mentioned by @fspindle, current compilation tutorial for ViSP python bindings in a conda environment was generating some warning at the cmake configuration step, as some system libraries were used by the build chain. This was due to the lack of installation of all build tools packaged by conda to enforce conda environment isolation.
Users/developers must install all the build tools packaged by conda:
conda install cmake cxx-compiler make
(or replace make by any other build system of your choice).

We may also want to switch the recommended build system for ninja on all plaftorms for more consistency (already used on Windows for ViSP conda package and planned to migrate for ubuntu/macOS as well).

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.84%. Comparing base (fe79ec1) to head (467d0c0).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   53.82%   53.84%   +0.01%     
==========================================
  Files         442      442              
  Lines       53850    53850              
==========================================
+ Hits        28987    28996       +9     
+ Misses      24863    24854       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

- add pkg-config package installation
- in known issues, add CMake Warning: Cannot generate a safe runtime search path section
@fspindle fspindle merged commit 1e447eb into lagadic:master Nov 26, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants