-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compat with opencv 5.x #1522
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- where instead of opencv_calib3d we use opencv_calib and opencv_3d modules - where instead of opencv_features2d we use opencv_features - clean a lot OpenCV modules detection Clean also known non optimal behavior of command line options
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1522 +/- ##
==========================================
+ Coverage 53.84% 53.85% +0.01%
==========================================
Files 441 441
Lines 53873 53869 -4
==========================================
+ Hits 29006 29012 +6
+ Misses 24867 24857 -10 ☔ View full report in Codecov by Sentry. |
…ericTracker-edge-KLT-scanline pass on Ubuntu 18.04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested outside ci
Particular attention has to be attached to test the following outside ci:
apps/calibration/*
modules/vision/testKeyPoint*
tutorial/detection/face/*
tutorial/detection/matching/*
tutorial/detection/object/*
tutorial/tracking/keypoint/tutorial-klt-tracker
tutorial/tracking/model-based/generic/tutorial-mb-generic-tracker-full
This PR is related to issue #1521