Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat with opencv 5.x #1522

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Fix compat with opencv 5.x #1522

merged 10 commits into from
Dec 17, 2024

Conversation

fspindle
Copy link
Contributor

@fspindle fspindle commented Dec 11, 2024

Tested outside ci

opencv opencv_contrib
macOS [x] 4.10.0 (brew) n/a
macOS [x] 5.0.0 (source) [x]
Ubuntu 24.04 [x] 4.6.0 (apt) [x]
Ubuntu 22.04 [x] 4.5.4 (apt) [x]
Ubuntu 24.04 [x] 4.4.0 (source) [x]
Ubuntu 20.04 [x] 4.2.0 (apt) [x]
Ubuntu 18.04 [x] 3.4.11 (source) [x]
Ubuntu 18.04 [x] 3.2.0 (apt) [x]
Ubuntu 16.04 [x] 2.4.9.1 (apt) [x]
Ubuntu 14.04 [x] 2.4.8 (apt) [x]

Particular attention has to be attached to test the following outside ci:

  • apps/calibration/*
  • modules/vision/testKeyPoint*
  • tutorial/detection/face/*
  • tutorial/detection/matching/*
  • tutorial/detection/object/*
  • tutorial/tracking/keypoint/tutorial-klt-tracker
  • tutorial/tracking/model-based/generic/tutorial-mb-generic-tracker-full

This PR is related to issue #1521

fspindle and others added 5 commits December 11, 2024 09:52
- where instead of opencv_calib3d we use opencv_calib and opencv_3d modules
- where instead of opencv_features2d we use opencv_features
- clean a lot OpenCV modules detection
Clean also known non optimal behavior of command line options
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 29.62963% with 19 lines in your changes missing coverage. Please review.

Project coverage is 53.85%. Comparing base (35f1f36) to head (a3d46f9).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
modules/vision/src/key-point/vpKeyPoint.cpp 5.26% 18 Missing ⚠️
modules/detection/src/face/vpDetectorFace.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1522      +/-   ##
==========================================
+ Coverage   53.84%   53.85%   +0.01%     
==========================================
  Files         441      441              
  Lines       53873    53869       -4     
==========================================
+ Hits        29006    29012       +6     
+ Misses      24867    24857      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ericTracker-edge-KLT-scanline pass on Ubuntu 18.04
@s-trinh
Copy link
Contributor

s-trinh commented Dec 11, 2024

@fspindle fspindle merged commit bbb1d8e into lagadic:master Dec 17, 2024
71 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants