Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMD support #8

Closed
wants to merge 1 commit into from
Closed

Add AMD support #8

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 12, 2016

Add support for using es6-promise-polyfill as a AMD module.

Note: I couldn't create a new promise.min.js because there are no instructions on how to do so (See #7).

@lahmatiy
Copy link
Owner

AMD is already supported. Use something like this:

define(["./path/to/promise.min.js"], function(Promise) {
    var promise = new Promise();
});

@ghost
Copy link
Author

ghost commented Jan 12, 2016

A bit of a misconfusion here: AMD is indeed supported but it doesn't work in browser (Using RequireJS). See #9 .

@ghost ghost closed this Jan 12, 2016
@lahmatiy lahmatiy mentioned this pull request Jan 12, 2016
@ghost ghost deleted the amd branch January 13, 2016 19:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant