You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
also, preferably not to commit to main directly since I might have made changes to that file on a different branch I think, and now if I ever try to merge, it will give a merge conflict
The reason will be displayed to describe this comment to others. Learn more.
Ok, feel free to revert then and maybe at the same time at some installation instruction in the README though.
I'm also not a big fan of pushing to main directly but recalled that we agreed this would be acceptable for small changes. If this is not wanted we should from now on clearly communicate that all changes go via PRs.
80d19c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to move them there for installability, since I set the path to the package in the
toml
file80d19c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it is actually not the typical way to lay out a Python project
https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/
https://blog.ionelmc.ro/2014/05/25/python-packaging/
https://hynek.me/articles/testing-packaging/
80d19c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is, I'd argue that we should revert this commit
80d19c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, preferably not to commit to
main
directly since I might have made changes to that file on a different branch I think, and now if I ever try to merge, it will give a merge conflict80d19c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, feel free to revert then and maybe at the same time at some installation instruction in the README though.
I'm also not a big fan of pushing to main directly but recalled that we agreed this would be acceptable for small changes. If this is not wanted we should from now on clearly communicate that all changes go via PRs.