Skip to content

Commit

Permalink
Move requirements and toml to src/ for proper installability
Browse files Browse the repository at this point in the history
  • Loading branch information
codingS3b committed Apr 11, 2024
1 parent c7a4ff7 commit 80d19c3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 0 deletions.
File renamed without changes.
File renamed without changes.

5 comments on commit 80d19c3

@AdrianM0
Copy link
Collaborator

@AdrianM0 AdrianM0 commented on 80d19c3 Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to move them there for installability, since I set the path to the package in the toml file

@kjappelbaum
Copy link
Collaborator

@kjappelbaum kjappelbaum commented on 80d19c3 Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjappelbaum
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is, I'd argue that we should revert this commit

@AdrianM0
Copy link
Collaborator

@AdrianM0 AdrianM0 commented on 80d19c3 Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, preferably not to commit to main directly since I might have made changes to that file on a different branch I think, and now if I ever try to merge, it will give a merge conflict

@codingS3b
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, feel free to revert then and maybe at the same time at some installation instruction in the README though.

I'm also not a big fan of pushing to main directly but recalled that we agreed this would be acceptable for small changes. If this is not wanted we should from now on clearly communicate that all changes go via PRs.

Please sign in to comment.