Allow access to VA endpoints via HTTP #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable http redirect and let envoy to do that.
Allow to access ocsp/crl service over http. It is a recommendation of RFCs.
haritzsaiz
reviewed
Nov 11, 2024
| @@ -71,6 +71,18 @@ data: | |||
| - name: backend | |||
| domains: ["*"] | |||
| routes: | |||
| - match: | |||
There was a problem hiding this comment.
I think we should add a comment explaining this change i.e. "Allow accessing VA services (CRL +OCSP) over HTTP without TLS. This is stated in RFC 5280 and it makes sense. Information only contains public non-confidential/sensitive data and contains signatures to prevent tampering and repudation"
| disabled: true | ||
| envoy.filters.http.jwt_authn: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.jwt_authn.v3.PerRouteConfig | ||
| disabled: true | ||
| - match: { prefix: "/" } |
There was a problem hiding this comment.
And then add another comment here: "All non-VA traffic redirect from HTTP to HTTPS"
| @@ -9,7 +9,7 @@ metadata: | |||
| nginx.ingress.kubernetes.io/ssl-passthrough: "true" | |||
| #Routed Service recives HTTPS connections | |||
| nginx.ingress.kubernetes.io/backend-protocol: "HTTPS" | |||
| nginx.ingress.kubernetes.io/force-ssl-redirect: "true" | |||
| nginx.ingress.kubernetes.io/force-ssl-redirect: "false" | |||
There was a problem hiding this comment.
Here also remove this line since it defaults to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to access OCSP/CRL endpoints over HTTP. It is a recommendation of RFCs.