Squash dict add test tags #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o squash-dict-add-test-tags
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 73.23% 66.71% -6.52%
==========================================
Files 11 12 +1
Lines 609 679 +70
==========================================
+ Hits 446 453 +7
- Misses 163 226 +63
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fmoletta
reviewed
Nov 28, 2022
fmoletta
previously approved these changes
Nov 28, 2022
Oppen
requested changes
Dec 6, 2022
Comment on lines
+103
to
+106
| self.hint_locals.insert( | ||
| "__dict_manager".to_string(), | ||
| PyDictManager::new().into_py(py), | ||
| ); |
There was a problem hiding this comment.
Let's just take the GIL here rather than run everything with it taken.
Comment on lines
+144
to
+145
| key: PyMaybeRelocatable, | ||
| val: PyMaybeRelocatable, |
There was a problem hiding this comment.
Why not always a BigInt here?
| vm: Rc<RefCell<VirtualMachine>>, | ||
| hint_value: Relocatable, | ||
| pub hint_value: Relocatable, |
| @@ -10,7 +10,7 @@ use std::{cell::RefCell, rc::Rc}; | |||
|
|
|||
| #[pyclass(name = "MemorySegmentManager", unsendable)] | |||
| pub struct PySegmentManager { | |||
| vm: Rc<RefCell<VirtualMachine>>, | |||
| pub(crate) vm: Rc<RefCell<VirtualMachine>>, | |||
| #[pyo3(get)] | |||
| memory: PyMemory, | |||
There was a problem hiding this comment.
It's got the VM already, do we really need to keep this instance around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #118
Add missing TEST comment to some hints in squash dict.