-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up memory + trace output comparison for contracts run in starknet-devnet tests #174
Open
fmoletta
wants to merge
58
commits into
main
Choose a base branch
from
add-trace-comparison
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
Add trace comparison to memory comparison target + workflow
Add trace comparison to devote memory comparison target + workflow
Dec 1, 2022
fmoletta
changed the title
Add trace comparison to devote memory comparison target + workflow
Add trace comparison to devnet memory comparison target + workflow
Dec 1, 2022
fmoletta
changed the title
Add trace comparison to devnet memory comparison target + workflow
Set up memory + trace output comparison for contracts run in starknet-devnet tests
Dec 7, 2022
10 tasks
Oppen
reviewed
Dec 22, 2022
|
||
|
||
if __name__ == '__main__': | ||
main() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\n
Juan-M-V
approved these changes
Jan 20, 2023
Co-authored-by: Mario Rugiero <[email protected]>
Oppen
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Makefile target
compare_memory_devnet
that runs the relevant starknet-devnet tests with cairo-rs-py runner and the original runner and compares the relocated memory + trace outputsAlso add a workflow that runs this target
NOTE: Current CI time for this new workflow is over 1 hour, some of it can be reduced by using cache
Steps:
write_binary_memory
in PyCairoRunnerFuture plans: