-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature): Adding general benchmark to Poseidon. #615
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 132 132
Lines 30013 30013
=======================================
Hits 28866 28866
Misses 1147 1147 ☔ View full report in Codecov by Sentry. |
@MauroToscano maybe we can also add it to these benchmarks https://github.com/mdvillagra/poseidon-benchmarks |
Tests and benchmarks shouldn't be coupled. If someone changes a test, benchmarks will change. They can share some common helper functions if needed, but they have to be different |
I just updated it and ran the benchmark with the bls12381 prime field. |
I'm closing this PR cause this is currently addressed in this PR: #703 |
Benchmarking Poseidon hash function
Description
Benchmark for the Poseidon implementation
Type of change
Checklist