-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/bn 254 #646
Feat/bn 254 #646
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
- Coverage 94.59% 94.34% -0.25%
==========================================
Files 144 148 +4
Lines 33838 34141 +303
==========================================
+ Hits 32008 32211 +203
- Misses 1830 1930 +100 ☔ View full report in Codecov by Sentry. |
* initial commit * change serde_cbor for serde_bare * bincode de/ser * remove comparison * fmt * restore flag * fix failing test * add std feature flag * conditional use * rmv conditional use * replace std for core * add cond import * rmv unused import * rplc todo w unimplemented * Update provers/cairo/src/main.rs --------- Co-authored-by: Mauro Toscano <12560266+MauroToscano@users.noreply.github.com>
* initial commit * change serde_cbor for serde_bare * bincode de/ser * remove comparison * fmt * restore flag * fix failing test * add std feature flag * conditional use * rmv conditional use * replace std for core * add cond import * rmv unused import * rplc todo w unimplemented * Update provers/cairo/src/main.rs --------- Co-authored-by: Mauro Toscano <12560266+MauroToscano@users.noreply.github.com>
* update wasm with new verifier api * fmt * Re add wasm compile and test * Add wasm commands to makefile * Add wasm commands to makefile * Fix wasm commands * Fix wasm * Fix wasm CI * Fmt * Fmt + fmt ci wasm * Compatibility with main * Fix * Fmt * Remove unnecesary clone * Fix linters * Raise security * Re add dep * Wasm --------- Co-authored-by: Mauro Toscano <12560266+MauroToscano@users.noreply.github.com> Co-authored-by: MauroFab <maurotoscano2@gmail.com>
d13d7e0
to
5335e45
Compare
math/src/elliptic_curve/short_weierstrass/curves/bn_254/twist.rs
Outdated
Show resolved
Hide resolved
impl ShortWeierstrassProjectivePoint<BN254TwistCurve> { | ||
/// This function is related to the map ψ: E_twist(𝔽p²) -> E(𝔽p¹²). | ||
/// Given an affine point G in E_twist(𝔽p²) returns x, y such that | ||
/// ψ(G) = (x', y', 1) with x' = x * x'' and y' = y * y'' | ||
/// for some x'', y'' in 𝔽p². | ||
/// This is meant only to be used in the miller loop of the | ||
/// ate pairing before the final exponentiation. | ||
/// This is because elements in 𝔽p² raised to that | ||
/// power are 1 and so the final result of the ate pairing | ||
/// doens't depend on having this function output the exact | ||
/// values of x' and y'. And it is enough to work with x and y. | ||
pub fn to_fp12_unnormalized(&self) -> [FieldElement<Degree12ExtensionField>; 2] { | ||
todo!() | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
impl ShortWeierstrassProjectivePoint<BN254TwistCurve> { | |
/// This function is related to the map ψ: E_twist(𝔽p²) -> E(𝔽p¹²). | |
/// Given an affine point G in E_twist(𝔽p²) returns x, y such that | |
/// ψ(G) = (x', y', 1) with x' = x * x'' and y' = y * y'' | |
/// for some x'', y'' in 𝔽p². | |
/// This is meant only to be used in the miller loop of the | |
/// ate pairing before the final exponentiation. | |
/// This is because elements in 𝔽p² raised to that | |
/// power are 1 and so the final result of the ate pairing | |
/// doens't depend on having this function output the exact | |
/// values of x' and y'. And it is enough to work with x and y. | |
pub fn to_fp12_unnormalized(&self) -> [FieldElement<Degree12ExtensionField>; 2] { | |
todo!() | |
} | |
} |
README.md
Outdated
|
||
testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing |
2a9c1d4
to
263c392
Compare
e5b80bf
to
7440724
Compare
796f9b4
to
0ecdb7b
Compare
8af2bfc
to
fb49110
Compare
b039326
to
c8339e9
Compare
Add BN254
Description
Implementation of BN254 #548 to be finished with @protocolwhisper
Implements:
Type of change
Please delete options that are not relevant.
Checklist