Add LogUp stark memory example #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #946 +/- ##
==========================================
+ Coverage 71.32% 71.40% +0.08%
==========================================
Files 155 155
Lines 33537 33574 +37
==========================================
+ Hits 23920 23975 +55
+ Misses 9617 9599 -18 ☔ View full report in Codecov by Sentry. |
nicole-graus
requested review from
pablodeymo,
diegokingston,
ilitteri and
Oppen
pablodeymo
reviewed
Jan 22, 2025
Comment on lines
11
to
12
| #[cfg(feature = "lambdaworks-serde-binary")] | ||
| #[cfg(feature = "alloc")] |
There was a problem hiding this comment.
this 2 lines can be combined in one using all
There was a problem hiding this comment.
Thanks, fixed here.
pablodeymo
reviewed
Jan 22, 2025
Comment on lines
+273
to
+275
| byte_slice.extend(ByteConversion::to_bytes_be(&self.value()[1])); | ||
| byte_slice.extend(ByteConversion::to_bytes_be(&self.value()[2])); | ||
| byte_slice.extend(ByteConversion::to_bytes_be(&self.value()[3])); |
There was a problem hiding this comment.
maybe it's better to use extend_from_slice
There was a problem hiding this comment.
Ok, changed here.
pablodeymo
reviewed
Jan 22, 2025
| use lambdaworks_crypto::fiat_shamir::is_transcript::IsTranscript; | ||
| use lambdaworks_math::field::traits::{IsField, IsPrimeField, IsSubFieldOf}; | ||
| use lambdaworks_math::{ | ||
| field::{element::FieldElement, traits::IsFFTField}, |
There was a problem hiding this comment.
Suggested change
| field::{element::FieldElement, traits::IsFFTField}, | |
| field::{element::FieldElement, traits::{IsField, IsPrimeField, IsSubFieldOf, IsFFTField}}, |
There was a problem hiding this comment.
Thanks, fixed here.
pablodeymo
approved these changes
Jan 22, 2025
diegokingston
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a continuous read-only memory stark example using LogUp.
This PR adds an example for the stark prover using the LogUp method for a permutation constraint.