Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quartic extension baby bear u32 #956

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nicole-graus
Copy link
Contributor

@nicole-graus nicole-graus commented Jan 8, 2025

Add Degree 4 extension field for Baby Bear in u32

Description

In this PR we add the Degree 4 Extension Field for our version of Baby Bear in u32. We also add the benchmarks for both versions of this extension (u64 and u32).

Results for 1 million operations:

Screenshot 2025-01-08 at 5 01 02 PM

Type of change

  • New feature

Checklist

  • Unit tests added
  • This change is an Optimization
    • Benchmarks added/run

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 78.98734% with 83 lines in your changes missing coverage. Please review.

Project coverage is 71.41%. Comparing base (6fb54a2) to head (77ff602).

Files with missing lines Patch % Lines
.../field/fields/fft_friendly/quartic_babybear_u32.rs 78.98% 83 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
+ Coverage   71.32%   71.41%   +0.08%     
==========================================
  Files         155      156       +1     
  Lines       33537    33932     +395     
==========================================
+ Hits        23920    24232     +312     
- Misses       9617     9700      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotabulacios jotabulacios marked this pull request as ready for review January 8, 2025 21:04
@jotabulacios jotabulacios requested a review from a team as a code owner January 8, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants