Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: making l1_batch_commit_data_generator_mode a non-mandatory attribute (Moved) #177

Open
wants to merge 4 commits into
base: feat_validium_pubdata_abstraction
Choose a base branch
from
Open

feat: making l1_batch_commit_data_generator_mode a non-mandatory attribute (Moved) #177

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9e8836
Implement serde solution
jorbush Feb 22, 2024
733d3e9
Use serve(default) instead
jorbush Feb 22, 2024
2f02dca
Add unit test
jorbush Feb 22, 2024
7692025
Refactor name
jorbush Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/lib/config/src/configs/chain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ pub enum L1BatchCommitDataGeneratorMode {
Validium,
}

fn default_l1_batch_commit_data_generator_mode() -> L1BatchCommitDataGeneratorMode {
L1BatchCommitDataGeneratorMode::Rollup
}

#[derive(Debug, Deserialize, Clone, PartialEq, Default)]
pub struct StateKeeperConfig {
/// The max number of slots for txs in a block before it should be sealed by the slots sealer.
Expand Down Expand Up @@ -123,7 +127,7 @@ pub struct StateKeeperConfig {

/// Number of keys that is processed by enum_index migration in State Keeper each L1 batch.
pub enum_index_migration_chunk_size: Option<usize>,

#[serde(default = "default_l1_batch_commit_data_generator_mode")]
jordibonet-lambdaclass marked this conversation as resolved.
Show resolved Hide resolved
pub l1_batch_commit_data_generator_mode: L1BatchCommitDataGeneratorMode,
}

Expand Down
Loading