Merge pull request #218 from samuelgmartins/3.11.x

Include exclamation point in month element format to prevent time-of-day related bugs
laminas · Jun 8, 2023 · 193b2e5 · 193b2e5
2 parents d0c94bd + 4cdb70e
commit 193b2e5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Element/Month.php b/src/Element/Month.php
@@ -16,7 +16,7 @@ class Month extends AbstractDateTime
      *
      * @var string
      */
-    protected $format = 'Y-m';
+    protected $format = '!Y-m';
 
     /**
      * Seed attributes

diff --git a/test/Element/MonthTest.php b/test/Element/MonthTest.php
@@ -5,6 +5,7 @@
 namespace LaminasTest\Form\Element;
 
 use DateInterval;
+use DateTime;
 use Laminas\Form\Element\Month as MonthElement;
 use Laminas\Validator\DateStep;
 use Laminas\Validator\GreaterThan;
@@ -81,4 +82,11 @@ public function testHTML5MonthValidation(string $value, bool $expected): void
         $monthValidator = $inputSpec['validators'][0];
         self::assertEquals($expected, $monthValidator->isValid($value));
     }
+
+    public function testTestDayTimeReset(): void
+    {
+        $element = new MonthElement('foo');
+        $date    = DateTime::createFromFormat($element->getFormat(), '2023-01');
+        self::assertEquals($date->format('d H:i:s'), '01 00:00:00');
+    }
 }