Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add implementation considerations section to address gap between serialization format and APIs in FIPS 203 #79

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

carl-wallace
Copy link
Contributor

No description provided.

draft-ietf-lamps-kyber-certificates.md Outdated Show resolved Hide resolved
draft-ietf-lamps-kyber-certificates.md Show resolved Hide resolved
seanturner and others added 2 commits December 11, 2024 11:18
Co-authored-by: Mike Ounsworth <[email protected]>
Co-authored-by: Mike Ounsworth <[email protected]>
Similarly, the algorithm that expands seed values is not listed as one of the "main algorithms" and features "internal" in the name even though it is clear that it is allowed to be exposed externally for the purposes of expanding a key from a seed.
Below are possible ways to extend the APIs defined in {{FIPS203}} to support serialization of seed values as private keys.

To support serialization of seed values as private keys, Algorithm 19 in {{FIPS203}} should return (ek, dk, d, z) on line 7 and Algorithm 16 should be promoted to be a "main algorithm" for external use in expanding seed values.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algorithm 19 in {{FIPS203}} should return

This sounds like we're redefining FIPS203 instead of extending it. Better to phrase it like let "alg 19b" denote the same procedure as algorithm 19 except that it returns (ek, dk, d, z) on line 7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carl-wallace are you going to suggest some changes I can merge in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying Bas' suggestion to the PR I sent yields something like this:

To support serialization of seed values as private keys, let Algorithm 19b denote the same procedure as Algorithm 19 in {{FIPS203}} except it returns (ek, dk, d, z) on line 7. Additionally, Algorithm 16 should be promoted to be a "main algorithm" for external use in expanding seed values.

@seanturner seanturner merged commit b020d2d into lamps-wg:main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants