Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to explain binding properties #94

Merged
merged 4 commits into from
Feb 2, 2025
Merged

Don't try to explain binding properties #94

merged 4 commits into from
Feb 2, 2025

Conversation

bwesterb
Copy link
Collaborator

@bwesterb bwesterb commented Jan 9, 2025

No description provided.

@csosto-pk
Copy link
Collaborator

Approved, but for posterity, why do you want to remove the extra explanation? For simplicity or to avoid inaccuracies?

Copy link
Collaborator

@csosto-pk csosto-pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with minor suggestion to fix. Not mandatory as it is already implied in the text. But I am suggesting to change it for clarity.

bwesterb and others added 2 commits January 10, 2025 12:07
Co-authored-by: Daniel Van Geest <daniel.vangeest@cryptonext-security.com>
Co-authored-by: Daniel Van Geest <daniel.vangeest@cryptonext-security.com>
@bwesterb
Copy link
Collaborator Author

Approved, but for posterity, why do you want to remove the extra explanation? For simplicity or to avoid inaccuracies?

Explaining these binding properties accurately and clearly, requires more than a sentence or two. At that point, I felt it's more appropriate to cover it in a different document.

@seanturner seanturner requested review from csosto-pk and removed request for csosto-pk January 13, 2025 15:27
@seanturner
Copy link
Collaborator

Will merge at the end of WGLC; see WGLC messages.

@seanturner seanturner merged commit f13806f into main Feb 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants