Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Espionage report visibility based on espionage level #316

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

Jbaukens
Copy link
Contributor

@Jbaukens Jbaukens commented Aug 25, 2024

Merge Request: Espionage Report Visibility Based on Espionage Level

Overview:

This merge request introduces logic to determine the visibility of information in espionage reports based on the difference in espionage levels between the attacker and the defender:

  • Espionage Report Visibility Logic:
    Implemented functionality to adjust the visibility of fleet, defense, buildings, and research in espionage reports according to the number of probes sent and the difference in espionage technology levels.

Testing:

  • Verified that the espionage report displays the correct information based on the difference in espionage levels.
  • Ensured that the functionality works correctly for both higher and lower espionage levels.

Next Steps:

  • Code review and merge upon approval.

Note:

  • Further tweaks might be necessary based on additional feedback or testing results.

Related Issue:

@lanedirt
Copy link
Owner

LGTM, merging!

PS: I didn't know of the existence for @forelse, nice to know that now 😄!


As an addition it would be nice to add a feature test for the espionage logic behaviour to help with potential refactoring later. I added a new separate issue for this which can be implemented later: #319.

@lanedirt lanedirt merged commit 33e86aa into lanedirt:main Aug 26, 2024
6 checks passed
@Jbaukens Jbaukens deleted the feature/espionage-visibility branch August 26, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement espionage report visibility limit based on espionage level
2 participants