Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'any' tool_choice handling in bind_tools #27

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix 'any' tool_choice handling in bind_tools #27

merged 1 commit into from
Oct 17, 2024

Conversation

B-Step62
Copy link
Collaborator

@B-Step62 B-Step62 commented Oct 17, 2024 •
edited
Loading

LangChain bind_tools accept any but OpenAI API does not recognize it. ChatOpenAI handles this by replacing any with required. This PR adds that handling to be compatible with OpenAI spec.

Test

  • Unit test
  • Ran integ test from local machine.

serena-ruan
serena-ruan approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

prithvikannan
prithvikannan approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@prithvikannan prithvikannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yuki!

@B-Step62 B-Step62 merged commit 469adc0 into langchain-ai:main Oct 17, 2024
8 checks passed
@B-Step62 B-Step62 deleted the fix-tool-choice branch October 17, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serena-ruan serena-ruan serena-ruan approved these changes

@prithvikannan prithvikannan prithvikannan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B-Step62 @prithvikannan @serena-ruan