Validate index name parameter #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: B-Step62 <[email protected]>
B-Step62
force-pushed
the
add-type-validation
branch
from
2fb11c0 to
ce3ac0f
Compare
|
@BenWilson2 This is a follow-up for the ES ticket - the issue was in users' code but this PR makes debugging easier. Would appreciate if you could take a look, thanks! |
BenWilson2
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
This is a great quality of life improvement for users! Thanks for adding this @B-Step62 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in LC community version,
DatabricksVectorSearchhadindexas the first argument of the constructor, which only accepts the index Python object returned from VS SDK'sget_indexAPI. This is inconvenient and also troublesome for migrating to Databricks SDK, so we replaced it with theindex_namestring argument in the new package.Some customers are not aware of this and still pass the index object. This will lead to an error from VS client saying
Invalid index name. Must specify the...which is not clear because the index itself has correct name.This PR adds a validation for the argument to show clearer error message.