Introduce deprecations to langchain-databricks #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
prithvikannan
commented
Dec 13, 2024
libs/databricks/README.md
Outdated
There was a problem hiding this comment.
not sure why we had two README's here, but this looks to be the one that gets published to pypi https://pypi.org/project/langchain-databricks/
efriis
approved these changes
Dec 13, 2024
efriis
reviewed
Dec 13, 2024
| @@ -58,6 +59,9 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| @deprecated( | |||
There was a problem hiding this comment.
oh actually probably not even worth calling out removal here because whole pacakge is deprecated
There was a problem hiding this comment.
i.e. we're unlikely to ever publish a 1.0 of this package
There was a problem hiding this comment.
adding back removal to pass lint. but agreed that we won't end up publishing 1.0
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README to reflect that
langchain-databricksshould be deprecated, and mark classes with@deprecatedannotations.