Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add master core install for lint/test/dev #14

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

efriis
Copy link
Member

@efriis efriis commented Apr 9, 2024

No description provided.

@efriis
Copy link
Member Author

efriis commented Apr 9, 2024

@cbornet integration tests seem to be failing for unrelated reason - let me know if it's due to a change in core!

@hemidactylus
Copy link
Collaborator

Hi, @efriis , thank you for taking care of this upgrade and spotting the test failure. It was indeed related to a randomness-induced flakiness, which is addressed in #15. That should be merged momentarily - and this PR, once rebased, will certainly pass.

Thank you!

@hemidactylus
Copy link
Collaborator

(I also believe that method async def aload(self) -> List[Document] can be removed from AstraDBLoader as it is now provided by the base class with 0.1.41, but this is not critical)

@cbornet
Copy link
Collaborator

cbornet commented Apr 10, 2024

@efriis #15 has been merged. Can you rebase the PR ?

@hemidactylus
Copy link
Collaborator

I should have been able to do it myself as one side was pure code and the other was pure dependencies. Could please @cbornet or @efriis take a look?

@hemidactylus hemidactylus requested a review from cbornet April 16, 2024 14:48
@cbornet cbornet merged commit 18caf27 into main Apr 16, 2024
13 checks passed
@cbornet cbornet deleted the erick/ci-add-master-core-install-for-lint-test-dev branch April 16, 2024 14:56
@efriis
Copy link
Member Author

efriis commented Apr 16, 2024

oops thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants