-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support in vector_store for server-side embeddings #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!
I've left some comments
Very nice and comprehensive work! My only suggestion concerns the fixtures around testing. With the vectorize feature eventually landing in prod, it could be better to prepare for that (something like a twin set of fixtures, vector- and vectorize-based) and add a small amount of skipifs to momentarily block the latter in prod? For ways to combine this with the pytest parametrize, I found a nice way to condition items of a parametrize (see here). |
Cool, this is a neat technique to know. I did look into using this pattern, but since we have several tests that use one or the other of the We could probably refactor the tests into separate modules for the different embeddings, then use the linked pattern in a further revision. |
Adds the
$vectorize
functionality to the vector store. Still uses the legacy astrapy paths.Note: does not add functionality to the cache.