Fix chat vertexai astream #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not pop the prompt from the conversation history which would pass an empty list of messages to the google client library.
mathiasburger
commented
Apr 12, 2024
| @@ -722,7 +719,6 @@ async def _astream( | |||
| project=self.project, | |||
| convert_system_message_to_human=self.convert_system_message_to_human, | |||
| ) | |||
| message = history_gemini.pop() | |||
There was a problem hiding this comment.
The variable message is currently unused.
It should not be removed from the history as generate_content_async requires the user message to be present in the contents parameter passed to the client, see https://ai.google.dev/api/python/google/generativeai/GenerativeModel#multi-turn.
|
thanks! we'll run a release later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not pop the prompt from the conversation history which would pass an empty list of messages to the google client library.