genai: update pyproject as vertexai #420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu007
force-pushed
the
genai_update_pyproject_as_vertexai
branch
from
3b64b20 to
3fbcd87
Compare
nobu007
force-pushed
the
genai_update_pyproject_as_vertexai
branch
from
3fbcd87 to
5a5f8c1
Compare
nobu007
force-pushed
the
genai_update_pyproject_as_vertexai
branch
6 times, most recently
from
9bf4893 to
35bb8f6
Compare
lkuligin
reviewed
Sep 6, 2024
libs/genai/pyproject.toml
Outdated
| @@ -46,6 +54,10 @@ codespell = "^2.2.0" | |||
| optional = true | |||
|
|
|||
| [tool.poetry.group.test_integration.dependencies] | |||
| numexpr = { version = "^2.8.8", python = ">=3.9,<4.0" } | |||
| google-api-python-client = "^2.114.0" | |||
| google-cloud-datastore = "^2.19.0" | |||
There was a problem hiding this comment.
we don't use this library in this project
There was a problem hiding this comment.
@lkuligin
I updated PR. Remove unused libs.
lkuligin
reviewed
Sep 6, 2024
libs/genai/pyproject.toml
Outdated
| numexpr = { version = "^2.8.8", python = ">=3.9,<4.0" } | ||
| google-api-python-client = "^2.114.0" | ||
| google-cloud-datastore = "^2.19.0" | ||
| langchain = { git = "https://github.com/langchain-ai/langchain.git", subdirectory = "libs/langchain" } |
There was a problem hiding this comment.
same here, why do we need this change?
There was a problem hiding this comment.
@lkuligin
I updated PR. Remove unused libs.
nobu007
force-pushed
the
genai_update_pyproject_as_vertexai
branch
from
35bb8f6 to
32655bc
Compare
nobu007
force-pushed
the
genai_update_pyproject_as_vertexai
branch
10 times, most recently
from
5779ee2 to
566a9ba
Compare
nobu007
force-pushed
the
genai_update_pyproject_as_vertexai
branch
from
566a9ba to
2ef7214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the pyproject.toml files for genai and vertexai, reducing maintenance costs.
Changes