Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added text-unicon to PALM family #580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added text-unicon to PALM family #580

wants to merge 1 commit into from

Conversation

lkuligin
Copy link
Collaborator

gawbul
gawbul suggested changes Oct 30, 2024
View reviewed changes
libs/vertexai/langchain_google_vertexai/_utils.py Outdated
@@ -138,7 +138,7 @@ def _missing_(cls, value: Any) -> "GoogleModelFamily":
return GoogleModelFamily.CODEY
if "medlm-medium@latest" in model_name:
return GoogleModelFamily.GEMINI
if "bison" in model_name or "medlm" in model_name:
if "bison" in model_name or "medlm" in model_name or "unicon" in model_name:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be unicorn here? Could you update, please 🙏

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to update myself but I don't have the permissions to push.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkuligin FYI 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, fixed

@gawbul
Copy link

gawbul commented Oct 31, 2024

Looks like some tests are failing, @lkuligin?
Not sure if they just need re-running, or if anything is broken with the change?
I unfortunately can't see the full build log on Google Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gawbul gawbul gawbul requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkuligin @gawbul