Update _parse_proto_output function to include the entity_id as part of the metadata returned #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the metadata returned. Currently similarity_search_by_vector() returns slightly different information when looking at a BQ store versus a Feature Store. When executed against a BQ store the nearest neighbor ID is returned, but when executed against the Feature Store no ID is returned. To bring both into alignment we should include the entity_id for the Online Feature Store as well.
lkuligin
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Allow similarity_search_by_vector() to return the entity_id as part of the metadata that is returned.
Currently similarity_search_by_vector() returns slightly different information when looking at a BQ store versus a Feature Store. When executed against a BQ store the nearest neighbor entity ID is returned, but when executed against the Feature Store no entity ID is returned. To bring both into alignment we should include the entity_id for the Online Feature Store as well.
Relevant issues
Type
🆕 New Feature
🐛 Bug Fix
Changes(optional)
Testing(optional)
Note(optional)