vertexai[patch]: remove allOf from function schema #96
Conversation
| if isinstance(v, dict) and "allOf" in v: | ||
| if isinstance(v["allOf"], list) and len(v["allOf"]) == 1: | ||
| obj = dict(v["allOf"][0]) | ||
| obj["title"] = v.get("title", obj.get("title", "")) |
There was a problem hiding this comment.
title field is now not supported - we are dropping it
| obj = dict(v["allOf"][0]) | ||
| obj["title"] = v.get("title", obj.get("title", "")) | ||
| obj["description"] = " ".join( | ||
| (v.get("description", ""), obj.get("description", "")) |
There was a problem hiding this comment.
I'm not sure about joining descriptions.
This code:
class Node(BaseModel):
"""This is a node"""
id: str
type: str
class Relationship(BaseModel):
source: Node
target: Node = Field(..., description="This is a target node")will produce following definition for target property:
{
"target": {
"title": "Target",
"description": "This is a target node This is a node",
"type": "object",
"properties": {
"id": {
"title": "Id",
"type": "string"
},
"type": {
"title": "Type",
"type": "string"
}
},
"required": ["id", "type"]
}
}There was a problem hiding this comment.
yea not ideal but is there a better generic solution? both descriptions could have important (and distinct) info
There was a problem hiding this comment.
I would consider coalescing i. e. field description should take precedence
class Relationship(BaseModel):
source: Node
target: Node = Field(..., description="This is a target node")
over model description:
class Node(BaseModel):
"""This is a node"""
id: str
type: str
And could you please describe reasoning and behaviour in the function doc string?
There was a problem hiding this comment.
i can get behind that, will update!
There was a problem hiding this comment.
@lkuligin what is your take on that?
patch for #95