Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subqueries building import query based on neo4j version #10

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

willtai
Copy link
Collaborator

@willtai willtai commented Nov 20, 2024

Summary

import_query uses Cypher syntax that is only available for Neo4j version 5.23 and above. This PRs adds a check to build the required query string.

Testing

This has been manually tested for both Neo4j versions 5.22 and 5.23. The graph_prompting.py script was used, which is adapted from this notebook.

Unit tests were added.

@willtai willtai force-pushed the update-deprecated-cypher branch 4 times, most recently from ceec904 to ea988a7 Compare November 20, 2024 15:04
@willtai willtai force-pushed the update-deprecated-cypher branch 2 times, most recently from 38fd439 to 6d6b4c8 Compare November 20, 2024 16:57
@willtai willtai force-pushed the update-deprecated-cypher branch from 6d6b4c8 to c18dec6 Compare November 21, 2024 12:46
@alexthomas93
Copy link
Collaborator

@CodiumAI-Agent /update_changelog

@CodiumAI-Agent
Copy link

Changelog updates: 🔄

Next

Updated

  • Improved subquery building for import queries to support different Neo4j versions.
  • Added unit tests for Neo4j version-specific query construction.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

@willtai willtai force-pushed the update-deprecated-cypher branch 2 times, most recently from ee66ce2 to e84234c Compare November 21, 2024 16:38
@willtai willtai force-pushed the update-deprecated-cypher branch from e84234c to 850ee1e Compare November 21, 2024 16:39
@willtai willtai requested a review from alexthomas93 November 21, 2024 17:06
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexthomas93 alexthomas93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willtai willtai merged commit cb12a54 into main Nov 22, 2024
8 checks passed
@CodiumAI-Agent
Copy link

Changelog updates: 🔄

Next

Updated

  • Added version-specific query building for Neo4jVector to support Neo4j versions < 5.23.
  • Introduced unit tests for version-dependent query logic in Neo4jVector.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

@alexthomas93 alexthomas93 deleted the update-deprecated-cypher branch January 13, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants