Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes #type: ignore comments #19

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Removes #type: ignore comments #19

merged 3 commits into from
Dec 9, 2024

Conversation

alexthomas93
Copy link
Collaborator

@alexthomas93 alexthomas93 commented Dec 8, 2024 •
edited
Loading

Description

This PR updates type information to remove all but 3 #type: ignore comments.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Project configuration change

Complexity

Medium

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Checklist

  • Unit tests updated
  • Integration tests updated
  • CHANGELOG.md updated

@alexthomas93 alexthomas93 force-pushed the bugfix/type-ignore-removal branch 3 times, most recently from 3fe5c1b to 6a44fbf Compare December 8, 2024 15:55
@alexthomas93
Copy link
Collaborator Author

@CodiumAI-Agent /update_changelog

@CodiumAI-Agent
Copy link

Changelog updates: 🔄

2024-12-09

Fixed

  • Removed unnecessary # type: ignore comments, improving type safety and code clarity.
  • Enhanced error handling and validation for various methods and parameters.
  • Updated tests to align with stricter type checking and improved mocking practices.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

@alexthomas93 alexthomas93 changed the title Bugfix/type ignore removal Removes #type: ignore comments Dec 9, 2024
@alexthomas93 alexthomas93 marked this pull request as ready for review December 9, 2024 14:09
@alexthomas93 alexthomas93 force-pushed the bugfix/type-ignore-removal branch from 4eb996c to 03bd6d1 Compare December 9, 2024 14:20
willtai
willtai approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@willtai willtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@alexthomas93 alexthomas93 merged commit 199d500 into langchain-ai:main Dec 9, 2024
8 checks passed
@alexthomas93 alexthomas93 deleted the bugfix/type-ignore-removal branch December 9, 2024 18:05
@CodiumAI-Agent
Copy link

Changelog updates: 🔄

2024-12-09

Fixed

  • Removed unnecessary # type: ignore comments, improving type safety and code clarity.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtai willtai willtai approved these changes

@stellasia stellasia Awaiting requested review from stellasia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexthomas93 @CodiumAI-Agent @willtai