Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds tests so that GraphCypherQAChain class now has 100% coverage #23

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Adds tests so that GraphCypherQAChain class now has 100% coverage #23

merged 6 commits into from
Dec 18, 2024

Conversation

alexthomas93
Copy link
Collaborator

@alexthomas93 alexthomas93 commented Dec 13, 2024 •
edited
Loading

Description

Adds tests so that GraphCypherQAChain class now has 100% coverage

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Project configuration change

Complexity

Medium

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Checklist

  • Unit tests updated
  • Integration tests updated
  • CHANGELOG.md updated

@alexthomas93 alexthomas93 marked this pull request as ready for review December 16, 2024 19:59
@alexthomas93 alexthomas93 changed the title Added tests to improve GraphCypherQAChain test coverage Adds tests so that GraphCypherQAChain class now has 100% coverage Dec 16, 2024
stellasia
stellasia approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@stellasia stellasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comment but none is blocking to me, nice work!

libs/neo4j/langchain_neo4j/chains/graph_qa/cypher.py Show resolved Hide resolved
libs/neo4j/tests/integration_tests/chains/test_graph_database.py Outdated Show resolved Hide resolved
libs/neo4j/tests/integration_tests/chains/test_graph_database.py Show resolved Hide resolved
@alexthomas93 alexthomas93 merged commit a53e8ee into langchain-ai:main Dec 18, 2024
8 checks passed
@alexthomas93 alexthomas93 deleted the feature/graph-qa-test-coverage branch December 18, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellasia stellasia stellasia approved these changes

@willtai willtai Awaiting requested review from willtai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexthomas93 @stellasia