fix: Cypher query extraction for node names with spaces #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `extract_cypher` to wrap node label with spaces in quotes. - Added tests for node names with one and multiple spaces. - Renamed test cases to improve clarity. - Checked lint and format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue in GraphCypherQAChain where node labels containing spaces (e.g., "Medical Condition") resulted in a Neo.ClientError.Statement.SyntaxError when generating Cypher queries. The issue was caused by node names with spaces not being wrapped in quotes, which are required for correct Cypher syntax.
Modified the extract_cypher function to wrap node names containing spaces in backticks.
Issue:
Fixes #28375
Dependencies:
N/A
Test Coverage:
Unit tests have been added to ensure that node names with single and multiple spaces are correctly wrapped in backticks.
Queries with already backtick-wrapped node names remain unaffected.
Lint and Test:
Ran
make format,make lint, andmake testto ensure all tests pass and the code adheres to the formatting standards.